Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODS: Copy ods themes to topicCategory instead of keywords #239

Merged
merged 1 commit into from
May 3, 2023
Merged

ODS: Copy ods themes to topicCategory instead of keywords #239

merged 1 commit into from
May 3, 2023

Conversation

tkohr
Copy link
Contributor

@tkohr tkohr commented May 2, 2023 •
edited
Loading

PR copies the ODS themes to topicCategory instead of the keywords.

For the record: An issue within this PR that inserted carriage returns during indexation was resolved by removing <gco:CharacterString> around the value select. Thanks, @jahow !

@tkohr tkohr marked this pull request as ready for review May 3, 2023 09:13
@jahow
Copy link
Contributor

jahow commented May 3, 2023

Don't forget to contribute this upstream, thanks :)

@tkohr
Copy link
Contributor Author

tkohr commented May 3, 2023

Thanks @jahow !

@tkohr tkohr merged commit 0cbacdf into georchestra-gn4.2.x May 3, 2023
@tkohr tkohr deleted the geor-ods-theme branch May 3, 2023 20:52
@fvanderbiest fvanderbiest added this to the 23.0 milestone May 4, 2023
@tkohr tkohr mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tkohr @jahow @fvanderbiest